Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CSP use with SWORD API responses #1743

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Prevent CSP use with SWORD API responses #1743

merged 1 commit into from
Jan 31, 2024

Conversation

marceloalencar
Copy link
Contributor

Do not send CSP headers with AtoM SWORD API responses.

Closes #1742

Do not send CSP headers with AtoM SWORD API responses.
@anvit anvit added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Jan 29, 2024
@anvit anvit added this to the 2.8.1 milestone Jan 29, 2024
@anvit
Copy link
Contributor

anvit commented Jan 31, 2024

Hi @marceloalencar!

Thank you so much for your contribution! This looks great and should resolve issues with uploading DIPs to AtoM from AM. We really appreciate you reporting this issue and providing a fix for this.

There's one minor thing we'd need before we can merge this change. Would you be able to sign our Contributor Agreement? I noticed you've signed one for Archivematica, but not one for AtoM.

Here's a link with the agreement and instructions on where to send it —
https://wiki.accesstomemory.org/Development/Contribute_code#Copyright_and_license

@marceloalencar
Copy link
Contributor Author

I've sent the signed Contributor Agreement for AtoM according to the provided instructions.

Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again @marceloalencar!

@anvit anvit merged commit 5f02d7f into artefactual:qa/2.x Jan 31, 2024
6 checks passed
@marceloalencar marceloalencar deleted the dev-csp-qtswordplugin branch January 31, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: QubitCSP filter missing on qtSwordPlugin
2 participants