Add URL support to D.O. load task (#1807) #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcantelon
force-pushed
the
dev/do-load-url-support
branch
from
0064781 to
fbdc92c
Compare
mcantelon
force-pushed
the
dev/do-load-url-support
branch
from
fbdc92c to
b6a7596
Compare
djjuhasz
approved these changes
May 2, 2024
There was a problem hiding this comment.
Looking good @mcantelon. I have a few minor suggestions but no blockers. 👌
| EOF; | ||
| $this->detailedDescription = "Load a CSV list of digital objects\n\n"; | ||
|
|
||
| $this->detailedDescription .= "Valid CSV columns are '".self::PATH_COLUMN."' and one of: '".implode("', '", self::IO_SPECIFIER_COLUMNS)."'"; |
There was a problem hiding this comment.
I think using sprintf() here is easier to read than string concatenation:
$this->detailedDescription .= sprintf(
"Valid CSV columns are '%s' and one of: '%s'",
self::PATH_COLUMN,
implode("', '", self::IO_SPECIFIER_COLUMNS),
);(line breaks optional)
| $valid = in_array(self::PATH_COLUMN, $columns); | ||
|
|
||
| // Second check for existance of an information object specifier column | ||
| if ($valid) { |
There was a problem hiding this comment.
This could be shortened using array_intersect()
if ($valid) {
$valid = count(array_intersect(self::IO_SPECIFIER_COLUMNS, $columns)) > 0;
}|
|
||
| $filename = basename($path); | ||
| // If it's not a file, assume it's a URL and dismiss if invalid | ||
| if (!filter_var($url_or_path, FILTER_VALIDATE_URL)) { |
| } | ||
|
|
||
| // Check if URL exists | ||
| $headers = @get_headers($url_or_path); |
|
Thanks @djjuhasz ! Good suggestions! |
mcantelon
force-pushed
the
dev/do-load-url-support
branch
2 times, most recently
from
622f3e9 to
76f3fec
Compare
Added functionality, to the digital object load task, to import URLs in addition to files. Did minor cleanup and improved CLI help to include a list of valid CSV columns.
mcantelon
force-pushed
the
dev/do-load-url-support
branch
from
76f3fec to
c2bad00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality, to the digital object load task, to import URLs in addition to files.
Did minor cleanup and improved CLI help to include a list of valid CSV columns.