Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related material improvements #1900

Open
wants to merge 3 commits into
base: qa/2.x
Choose a base branch
from

Conversation

mInnes-archives
Copy link
Contributor

@mInnes-archives mInnes-archives commented Dec 3, 2024

PR adds some small improvements to how related materials are listed in descriptions and in relevant edit forms:

  1. If draft descriptions are linked, these will now only be visible to authenticated users. [bug fix]
  2. The title of linked descriptions now include the level of description and reference code for descriptions with such values, as well as the draft status when relevant. Both BS2 & BS5 themes are covered.

With regards to the second point, given that titles can be fairly generic in an archival context, just having the title alone ends up being really unclear and unhelpful at times. At BC Archives we have been avoiding using the 'Related materials' field because of how it displays. We've just been using the 'Associated materials' field instead, which technically isn't what it's intended for. Hopefully this can help get us using the appropriate field in the future and benefit from having reciprocal links. I imagine there are others who might be avoiding it or finding it not as clear as it could be for users for similar reasons.

Adds level of decription, refcode, and draft status to existing
related descriptions following autocomplete title format.
Linked draft material descriptions now only visible to authenticated users
Adds level of description, refcode, and draft status to
related materials titles.
@sarah-mason
Copy link

Hi @mInnes-archives - thanks for your contribution! As the Contributor Success Specialist, I wanted to update you on this PR. I have notified Enterprise services about this and they will be contacting you in the new year to move forward. I will also discuss this further with the AtoM Maintainers. If you have any additional questions, feel free to contact me or the Community Team at contributors@artefactual.com

@mInnes-archives
Copy link
Contributor Author

mInnes-archives commented Dec 18, 2024

Thanks for the update @sarah-mason.

I have notified Enterprise services about this and they will be contacting you in the new year to move forward.

Assuming I'm understanding this correctly, I'd like to provide some clarification to avoid some confusion - if Enterprise Services is to contact whomever our point of contact is at BC Archives, it's unlikely that they will know anything about this PR. I'm just an Archivist who works for BC Archives at the moment. I only mentioned my place of work to give some real world justification since some of this is motivated by conversations I've had with some of the other Archivists regarding why we aren't using this field. This is more in line with the stuff I've done in the past as an independent community contributor for AtoM. It's more of a hobby.

@sarah-mason
Copy link

Thank you for the additional context - if Enterprise does contact want to anyone about it, I have recommended they contact you first. We welcome all to contribute and having user experience of AtoM's and its features (and its bugs) can be useful for deciding what to tackle with development. I am bringing this to the AtoM Maintenance team to discuss as well, so we will be in contact further by the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants