Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create argument to sort AIPs #50

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

Dhwaniartefact
Copy link
Contributor

This PR creates an argument --sort to display the results of fixity check error messages on top and success messages below.

Connected to archivematica/Issues#1681

Copy link
Member

@replaceafill replaceafill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @Dhwaniartefact, but I think we should extend that new test case to assert it's actually separating errors and successes as you describe.

tests/test_fixity.py Outdated Show resolved Hide resolved
@Dhwaniartefact Dhwaniartefact merged commit d5d9f2c into master Sep 25, 2024
8 checks passed
@Dhwaniartefact Dhwaniartefact deleted the dev/issue-create-argument-to-sort-aips branch September 25, 2024 20:26
Copy link
Member

@amayita amayita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants