-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to landmark #35
Go to landmark #35
Conversation
60f955b
to
97256cc
Compare
Wow! Interesting and usefull feature. Initially I wished to make similar list of landmarks with edit/detele actions (like in Yandex Maps application). But then realized that it be more convenient to do this directly on the map. Besides it will be a good idea to zoom to choosen landmark (how did i do in "Follow me" command). |
Hi, @artem78 !
"Go to... -> Landmark" allows move to a landmark by selecting from the list dialog. Do you have any objections (especialy to the second item)? |
Nice to hear that you are interested to make contribution to this project. I suggest you to make 2 separate pull requests - for fixes and for new features. I planned to publish v1.5.1 soon with fixes (mainly for landmarks) and add new features later.
You are right. It will be better to fix this.
I think this is not really necessary, but if you want you may add this. There is my list of TODOs:
|
97256cc
to
1f5891a
Compare
I've separated the update-landmark-fix from this pull request. |
1f5891a
to
5a984f2
Compare
|
Hello, @artem78. |
@baranovskiykonstantin Okay! |
I implemented this in #49. |
Symbian 9.1 has no overloaded Could you please fix this? Thanks. |
No description provided.