Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to landmark #35

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Conversation

baranovskiykonstantin
Copy link
Contributor

No description provided.

@artem78
Copy link
Owner

artem78 commented Jul 31, 2021

Wow! Interesting and usefull feature.

Initially I wished to make similar list of landmarks with edit/detele actions (like in Yandex Maps application). But then realized that it be more convenient to do this directly on the map.

Besides it will be a good idea to zoom to choosen landmark (how did i do in "Follow me" command).

@baranovskiykonstantin
Copy link
Contributor Author

Hi, @artem78 !
I'm going to add a couple of features/fixes related to the landmarks.

  1. On touchscreen devices the center crosshair jumps around when the device orientation changes or when the softkays appear. The coordinate under the crosshair must remain unchanged in this cases, I think.
  2. It would be great to move the "Go to..." item in the top menu pane and assign the submenu to it with two subitems:
  • Landmark
  • Coordinate

"Go to... -> Landmark" allows move to a landmark by selecting from the list dialog.
"Go to... -> Coordinate" allows move to a coordiate by entering latitude/longitude in custom query dialog.

Do you have any objections (especialy to the second item)?

@artem78
Copy link
Owner

artem78 commented Jul 31, 2021

Hi, @baranovskiykonstantin.

I'm going to add a couple of features/fixes related to the landmarks.

Nice to hear that you are interested to make contribution to this project. I suggest you to make 2 separate pull requests - for fixes and for new features. I planned to publish v1.5.1 soon with fixes (mainly for landmarks) and add new features later.

On touchscreen devices the center crosshair jumps around when the device orientation changes or when the softkays appear. The coordinate under the crosshair must remain unchanged in this cases, I think.

You are right. It will be better to fix this.

"Go to... -> Coordinate" allows move to a coordiate by entering latitude/longitude in custom query dialog.

I think this is not really necessary, but if you want you may add this.


There is my list of TODOs:

  • Delete landmark with C key (done!)
  • Add or rename exists landmark with central key (done!)
  • Show crosshair only when map moves and hide after a couple of seconds after (done!)
  • Many landmarks look very messy (see second item in list):
    Snap3775

@baranovskiykonstantin
Copy link
Contributor Author

I've separated the update-landmark-fix from this pull request.

@artem78 artem78 added the enhancement New feature or request label Aug 9, 2021
@baranovskiykonstantin
Copy link
Contributor Author

  1. It would be great to move the "Go to..." item in the top menu pane and assign the submenu to it with two subitems:
  • Landmark
  • Coordinate

"Go to... -> Landmark" allows move to a landmark by selecting from the list dialog.
"Go to... -> Coordinate" allows move to a coordiate by entering latitude/longitude in custom query dialog.

I've just finished the implementation of this feature:
Scr000006 Scr000005

@artem78 artem78 merged commit 3655faf into artem78:develop Nov 22, 2021
@artem78
Copy link
Owner

artem78 commented Dec 2, 2021

Hi, Konstantin!

I substantially increased list drawing speed for a large number of landmarks (hundreds). My wish is to add search. Could you make this?

Snap3890

@baranovskiykonstantin
Copy link
Contributor Author

Hello, @artem78.
I have no time at the moment :( Maybe in the future.

@artem78
Copy link
Owner

artem78 commented Dec 2, 2021

@baranovskiykonstantin Okay!

@artem78
Copy link
Owner

artem78 commented Apr 26, 2022

My wish is to add search. Could you make this?

I implemented this in #49.

@artem78
Copy link
Owner

artem78 commented Sep 18, 2022

Hi @baranovskiykonstantin !

Symbian 9.1 has no overloaded CAknMultiLineDataQueryDialog::NewL for coordinates type. That's why the program can't run on Symbian 9.1 phones. I suggest to make dialog with two float fields instead.

Could you please fix this?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants