-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README re: Helix editor configuration #97
Conversation
If accepted, I would love to get this PR labeled "hacktoberfest-approved", though I understand if this project doesn't want to get involved. |
Hi @ngraham20! Thanks for your contribution. I'd suggest keeping |
Oh actually yeah, I hadn't thought of that, but yes seeing Helix specifically listed was what got me excited to begin with! |
I don't know whether GH notifys when new commits are added to an existing PR, but just in case, I re-added in the Helix support to the README doc |
@ngraham20 thank for adjusting the PR! There's just one more comment re: the phrasing |
Oh oops I marked resolved, thinking it would auto apply your suggestion. I can't tell if it did that or if I need to push the change myself. I'll check when I get to my computer |
Co-authored-by: Artem Pyanykh <arr@fb.com>
Ah, there we go, the mobile app doesn't have the "commit suggestion" button. I've updated the README with your suggestions. |
oh, super sorry, the label is "hacktoberfest-accepted". If you don't mind, could you swap that around? |
Fixed the label. Thanks for the contribution @ngraham20! |
Thank you! Glad to contribute :D |
helix#4399 was merged. After installing the marksman binary, markdown worked in Helix as expected.