Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backdrop for center position #18

Merged
merged 1 commit into from
Jul 15, 2017
Merged

Conversation

ktriek
Copy link
Contributor

@ktriek ktriek commented Jul 14, 2017

Fixed backdrop for positions:
Center_center
Left_center
Right_center

@artemsky
Copy link
Owner

It does not fix that issue.
The reason is that now all toast will append at the bottom. Right from the center of screen

How it should be?
Toasts should be re-centered every creation. So all of them could fit at the screen center

How to?
I think we should calculate snotify-component height, and append negative margin after each ngAfterViewChecked

p.s.: i am really knew about this issue. It css bug for now. They should fix it next versions.

But for i appreciate your pull request, and i'll take it right after i find a way to append negative margin in a right way.

@artemsky artemsky merged commit a2889a3 into artemsky:master Jul 15, 2017
@ktriek
Copy link
Contributor Author

ktriek commented Jul 15, 2017

@artemsky thank you very much for the review and the great work you are doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants