Double quote escaping #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
J-Brk
commented
Nov 24, 2021
•
J-Brk
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | ✔️ |
| Fixed issues | #189 |
- Implementation of escaping of double quotes as mentioned in Problem with "" in Title. #189.
- Equalized code structure between OpenGraph and TwitterCards for neater implementation of the fix.
Equalize code structure
Implements double quote escaping & moved cleaning to separate function
|
@vinicius73 Can you see why my PR is only running 1 check instead of 2 & can you merge it? |
|
@vinicius73 Can you give this one a push for merging? Sometimes it takes very long before some issues are resolved and I guess you are very busy. Maybe you can assign me and some others some roles so we can boost up the development / progress of this package? |
|
A little reminder about this PR @vinicius73 :) |
|
Hi @J-Brk sorry for the long delay. |
This was referenced Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.