Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 9 support #267

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Add Laravel 9 support #267

merged 1 commit into from
Feb 8, 2022

Conversation

gbuckingham89
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues comma-separated list of tickets # fixed by the PR, if any

This PR simply adds support for Laravel 9 (released today).

@emtudo emtudo merged commit 90dd581 into artesaos:master Feb 8, 2022
@J-Brk
Copy link
Collaborator

J-Brk commented Feb 8, 2022

@emtudo Isn't it too fast to already merge this PR? Have we done tests to confirm the package actually works well under Laravel 9? Do we need to add unit tests? How about the documentation?

@emtudo
Copy link
Member

emtudo commented Feb 9, 2022

Laravel 9 is basically version 8. The structure hasn't changed, if it works on version 8, it has to work on version 9.

@sawirricardo
Copy link

composer not yet updated?

Using version ^0.21.0 for artesaos/seotools
./composer.json has been updated
Running composer update artesaos/seotools
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires artesaos/seotools ^0.21.0 -> satisfiable by artesaos/seotools[v0.21.0].
    - artesaos/seotools v0.21.0 requires illuminate/config 5.8.* || ^6.0 || ^7.0 || ^8.0 -> found illuminate/config[v5.8.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but these were not loaded, likely because it conflicts with another require.

You can also try re-running composer require with an explicit version constraint, e.g. "composer require artesaos/seotools:*" to figure out if any version is installable, or "composer require artesaos/seotools:^2.1" if you know which you need.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

@emtudo
Copy link
Member

emtudo commented Feb 9, 2022

A version tag has not yet been created.

@emtudo
Copy link
Member

emtudo commented Feb 10, 2022

Added tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants