Skip to content
This repository has been archived by the owner on Jun 25, 2021. It is now read-only.

Commit

Permalink
Add note re Membership Dates
Browse files Browse the repository at this point in the history
  • Loading branch information
aydun committed Nov 14, 2018
1 parent 537cba4 commit dbbf41c
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions MembershipDates.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Membership Dates

In a simple world, someone fills in a membership form, pays by credit card and their membership is active immediately.

In the DD world, things happen on different dates:
1. `setup_date` - fill in a membership form, complete a DD mandate
- Recurring Contribution created with status Pending
- Contribution created with status Pending
- Membership created with status Pending, `join_date = start_date = setup_date`
2. `charge_date` - first payment charged
3. `webhook_date` - GC fires webhook and notifies of `charge_date`
- Recurring Contribution updated to In Progress
- Contribution updated to status Completed, `receive_date` updated to `charge_date`
- Membership updated to status New, `join_date` unchanged, `start_date` updated to `webhook_date`, `end_date` updated to `start_date` + membership_length

This appears to be identical date behaviour to creating a membership with a pending cheque payment and then later recording the cheque as being received. The membership will start when the payment is recorded and the contribution status set to Completed. The end date is recalculated to be a year (or other membership length) from the start date so that members get a full year of benefit.

However ... some might want the membership to start as soon as the mandate is setup, before waiting for the first payment. The current date logic is handled by core so this extension would need to override that in a couple of places to implement a different scheme. Since that is not specific to this payment processor, it might be better to do this as an enhancement to core, or a separate extension.

0 comments on commit dbbf41c

Please sign in to comment.