New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic bug #15

Closed

artfulrobot opened this issue Jun 23, 2022 · 0 comments

Owner

artfulrobot commented Jun 23, 2022 •

edited

Loading

if email not found, but name does it uses name only even if that contact has a different email. This should be a suggestion at best.

Consider the case:

Allie Aardvark allie@example.org has made a donation and you want to import it.
You don't have anyone with allie@example.org in your CRM, but you do have an Allie Aardvark (it's such a common name) with email aardvark@example.com
It's possible that these two Allies are the same. Or not.

Currently the helper will go like so:

Can I find a match of the email? No.
OK, let's try the name. Ah ha, a single match. It must be the right contact.

That last bit is flawed; we can't know from just a name match. The UI should present the user with options to select this Allie, or add new.

artfulrobot added a commit that referenced this issue


          Fix issue #15 (assuming a name match is ok)

f136ce4

artfulrobot closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment