Improve error handling #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthaud
requested changes
Nov 15, 2020
| @@ -29,7 +30,7 @@ def printf(fmt, *args, file=sys.stdout): | |||
|
|
|||
| def is_html(response): | |||
| ''' Return True if the response is a HTML webpage ''' | |||
| return '<html>' in response.text | |||
| return "html" in response.headers["Content-Type"] | |||
| result = self.do_task(task, *self.args) | ||
| try: | ||
| result = self.do_task(task, *self.args) | ||
| except Exception as e: |
There was a problem hiding this comment.
We don't need e here, we could just except:?
Comment on lines
+199
to
+202
| verification = verify_response(response) | ||
| if not verification[0]: | ||
| printf(verification[1], url, filepath) | ||
| return [] |
There was a problem hiding this comment.
Here and below: Instead of using verification[0] and verification[1] we could use unpacking:
valid, error_message = verify_response(response)
if not valid:
printf(error_message, url, filepath)
return []
Comment on lines
-315
to
-316
| elif not response.text.startswith('ref:'): | ||
| printf('error: %s/.git/HEAD is not a git HEAD file\n', url, file=sys.stderr) |
| return 1 | ||
|
|
||
|
|
There was a problem hiding this comment.
nitpick: remove the empty newline
|
Could you please apply my suggested changes and update the pull request? |
|
I would love if this could be approved, this is an amazing change |
|
Since the author wouldn't apply my suggested changed, I did that myself. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an exception handler to Worker.run so a single failed task doesn't crash the whole worker, and also added logic to check for HTML responses (error pages that give a 200 response code instead of 404) and zero-length responses (I've run into them, surprisingly).