Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sort param to get test run by id #106

Merged
merged 6 commits into from
Dec 20, 2023
Merged

add sort param to get test run by id #106

merged 6 commits into from
Dec 20, 2023

Conversation

cheungrowan
Copy link
Contributor

@cheungrowan cheungrowan commented Dec 19, 2023 •
edited
Loading

  • add a sort param to .../runs/{run_id} . Possible values are score,order, defaults to order. This is necessary to ensure that run data can be returned in the same order during side by side comparison
  • refactor sort parameter code across client and server to use enums and fastapi annotations to validate sort parameters

@cheungrowan cheungrowan requested a review from vivirose December 19, 2023 21:05
edinpeter
edinpeter reviewed Dec 19, 2023
View reviewed changes
arthur_bench/client/local/client.py Outdated Show resolved Hide resolved
arthur_bench/server/run_server.py Outdated Show resolved Hide resolved
edinpeter
edinpeter previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@edinpeter edinpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vivirose
Copy link
Contributor

The FE changes look good to me

@cheungrowan cheungrowan merged commit 5b5601d into main Dec 20, 2023
11 checks passed
@cheungrowan cheungrowan deleted the runs-sort-param branch December 20, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivirose vivirose vivirose approved these changes

@edinpeter edinpeter edinpeter left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheungrowan @vivirose @edinpeter