These are the VFD conf files from https://github.com/ophub/amlogic-s9…

[phodina]

Hi,

I found these configuration files for VFD driver/daemon on unofficial repository for Armbian.

The configuration for X96 Max Plus works for me and it would be great to merge them into one.

With the permission of the author.

[arthur-liberman]

Can you please rename the files to follow the naming convention that the rest of the vfd files have?

[arthur-liberman]

Does this t95m-s905x-vfd have the wrong config? Or are there multiple S905X variations? I'm pretty sure I still have a S905X T95m, and the config in my repo definitely works.
If this config is correct, please rename it to t95m-s905x-2-vfd.conf and I will rename the existing one with 1.

[phodina]

I can't guarantee the validity of this config as I don't own the device. If you want I can just remove this device and use your configuration.

[arthur-liberman]

Dup tanix-tx9-pro-vfd.conf

[phodina]

--- tx9-pro.conf	2023-06-10 00:27:36.961211989 +0200
+++ tanix-tx9-pro-vfd.conf	2023-06-10 00:27:17.505131843 +0200
@@ -1,14 +1,14 @@
 # This file must be renamed to vfd.conf and placed in the /storage/.config/ folder.
 #
-# Tanix TX9 Pro (S912) configuration
+# Tanix TX9 Pro configuration
 #--------------------
 #gpio_xxx:
 # [0] 0 = &gpio, 1 = &gpio_ao.
 # [1] pin number - https://github.com/openSUSE/kernel/blob/master/include/dt-bindings/gpio/meson-gxl-gpio.h
 # [0] Reserved - must be 0.

-vfd_gpio_clk='0,75,0'
-vfd_gpio_dat='0,74,0'
+vfd_gpio_clk='0,76,0'
+vfd_gpio_dat='0,75,0'
 vfd_gpio_stb='0,53,0'

 #chars:
@@ -34,6 +34,3 @@
 # [3] - Controller.

 vfd_display_type='0x00,0x00,0x00,0x00'
-
-#functions='alarm usb play pause colon lan wlan'
-functions=''

Are you sure? The vfd_gpio_clk and vfd_gpio_dat are allocated to different pins.

[arthur-liberman]

Same as x96air, maybe worth unifying them?

[arthur-liberman]

Same as above.

[arthur-liberman]

Thanks for this, but I made some comments, as I can't accept it as-is.

[phodina]

Hi @arthur-liberman,

thanks for the review. I've applied most of your points.

[arthur-liberman]

Thanks!
Mostly nitpicking, but I'd like names to be consistent. It makes it easier for me to track/find things later.

[phodina]

No problem. I also like consistency at least in names since the component-wise it's a mess on these boxes :-D

[arthur-liberman]

This is great, thank you.