Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

Add option to not include "orientation" attribute #84

Closed
feg624 opened this issue Sep 6, 2018 · 1 comment
Closed

Add option to not include "orientation" attribute #84

feg624 opened this issue Sep 6, 2018 · 1 comment

Comments

@feg624
Copy link

feg624 commented Sep 6, 2018

While testing my PWA on Android, I see that whenever I provide some value to the orientation attribute on the resulting manifest.json, the PWA doesn't use the device screen orientation (locked, or not), but it always uses the one provided into the manifest.json.

However, when preparing the manifest.json file manually (without this plugin), and leaving it without the orientation attribute, the PWA uses the screen orientation that the user selects on the OS.

I think it would be good if we could customize the plugin so that we can leave the manifest.json without this attribute.

Regards,

Franco

doug-wade added a commit to doug-wade/webpack-pwa-manifest that referenced this issue Nov 27, 2018
doug-wade added a commit to doug-wade/webpack-pwa-manifest that referenced this issue Dec 1, 2018
doug-wade added a commit that referenced this issue Dec 1, 2018
[#84]: Add option to omit orientation
@feg624
Copy link
Author

feg624 commented Dec 1, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants