Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

Fix dir of the filename not being preserved #29

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

satazor
Copy link
Contributor

@satazor satazor commented Dec 12, 2017

Fixes #28

With this change, if filename is foo/manifest.json, the manifest.json file will be created inside foo.

Do not merge yet, @paulobmarcos will test it out manually since there's no unit tests for this package 😢

@satazor
Copy link
Contributor Author

satazor commented Dec 13, 2017

@arthurbergmz We confirmed that the changes work correctly after @paulobmarcos tests.

Hope that this gets merged, it's currently blocking a feature on a project 😢

@arthurbergmz
Copy link
Owner

I'm gonna merge it and improve some code of mine. There's going to have a release by this time tomorrow.

Thank you, guys!

@arthurbergmz arthurbergmz merged commit dbf0e4d into arthurbergmz:master Dec 14, 2017
@satazor satazor deleted the keep-filename-dir branch December 14, 2017 15:34
@satazor
Copy link
Contributor Author

satazor commented Dec 14, 2017

<3

@arthurbergmz
Copy link
Owner

v3.3.3

Please, update.

@satazor
Copy link
Contributor Author

satazor commented Dec 15, 2017

@arthurbergmz the index.js file tries to require dist/index.js but that file was not published :/

@arthurbergmz
Copy link
Owner

@satazor I've just checked that, I'm looking into it

@arthurbergmz
Copy link
Owner

@satazor Done, please, update to v3.3.4.

Thank you!

@Guymestef
Copy link

Hello,

Since this update, each time my project is rebuild through webpack-hot-middleware, a new folder dist with a manifest file is created inside the previously created dist folder... ^_^'

@arthurbergmz
Copy link
Owner

@Guymestef

Hello, can you create an issue describing what is exactly happening, with your WebpackPwaManifest config? Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants