Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): pass error prop to Form.Field #708

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

arthurdenner
Copy link
Owner

What kind of change does this PR introduce?
Bug fix. Closes #707.

What is the current behavior?
When an input inside a Form has error, isn't styled properly.

What is the new behavior?
The input is styled properly.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@vercel
Copy link

vercel bot commented Jan 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/CTLZaimXKyjKw1LW5ZyRMTPmiH12
✅ Preview: https://react-semantic-ui-datepickers-git-fix-error-366277-arthurdenner.vercel.app

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #708 (751a0b4) into develop (578dc27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #708   +/-   ##
========================================
  Coverage    95.41%   95.41%           
========================================
  Files           16       16           
  Lines          524      524           
  Branches       100      100           
========================================
  Hits           500      500           
  Misses          24       24           
Impacted Files Coverage Δ
src/components/input.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c1707...751a0b4. Read the comment docs.

@arthurdenner arthurdenner merged commit 5603059 into develop Jan 13, 2022
@arthurdenner arthurdenner deleted the fix/error-FormField branch January 13, 2022 16:32
@github-actions
Copy link

🎉 This PR is included in version 2.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using react-semantic-ui-datepicker with formik-semantic-ui-react
1 participant