Fix Cron to Set Flights Visible to True Only When Owned By The Core (n…

…abeelio#1770)

* Set Visible to True Only When Owned By The Core

* Better Syntax

* Ammended based on Dispo's Feedback

* Applied changes based on feedback.

* Corrected Logic. Corrected database seeder for Flights

* Fix for style-cl

---------

Co-authored-by: Nabeel S. <nabeelio@users.noreply.github.com>

app/Cron/Nightly/SetActiveFlights.php

@@ -34,7 +34,7 @@ public function handle(CronNightly $event): void
     public function checkFlights(): void
     {
         $today = Carbon::now('UTC');
-        $flights = Flight::all();
+        $flights = Flight::where('active', 1)->whereNull('owner_type')->get();
 
         /**
          * @var Flight $flight
@@ -43,8 +43,7 @@ public function checkFlights(): void
             if (!$flight->active) {
                 continue;
             }
-
-            // Set to visible by default
+            // Set visible default
             $flight->visible = true;
 
             // dates aren't set, so just save if there were any changes above

app/Database/factories/FlightFactory.php

@@ -55,7 +55,7 @@ public function definition(): array
                 DateTime::ATOM
             ),
             'updated_at' => static fn (array $flight) => $flight['created_at'],
-            'owner_type' => Flight::class,
+            'owner_type' => null,
             'owner_id'   => null,
         ];
     }