Allow engine node 12.x.x #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://levelup.gitconnected.com/whats-new-in-node-12-e00111ffb83f: Node.js continues its yearly release cycle with version 12 (codenamed Erbium). Since this is as even-numbered version, it will go into Long Term Support (LTS) beginning on October 2019 and reach its end of life in April 2022. What's the justification for having these constraints after all?? I'm using `yarn install --ignore-engines` all the time, never had any issues. Not on node `v11.x.x` not on `v12.x.x`. I would love to drop those constraints altogether. <3 Archlinux + rolling releases close arthurvasconcelos#19
I had a quick look into the documentation of these constraints: git@github.com:roschaefer/vue-izitoast.git Regarding the `npm` constraints they say: > this field is advisory onlyreasoning so even they are not really confident on the usefulness of the constraints for `npm`. Can we just be optimistic and assume it works fine? If people get back to us with problems we can still add a constraint if we *know* there are any issues. I cannot see anything in the code of this package that would justify having these constraints. This commit makes arthurvasconcelos#20 obsolete. If I missed anything here I would love if you could inform me about why we have the constraints at all.
yarn and npm should not be used in the same project.
I really recommend a service like https://dependabot.com/ for this kind of job. Used together with a build server it's an excellent service.
|
fixed at 98ef214 :) |
roschaefer
added a commit
to Human-Connection/Human-Connection
that referenced
this pull request
Aug 23, 2019
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://levelup.gitconnected.com/whats-new-in-node-12-e00111ffb83f:
What's the justification for having these constraints after all?? I'm using
yarn install --ignore-enginesall the time, never had any issues. Not on nodev11.x.xnot onv12.x.x. I would love to drop those constraints altogether.❤️ Archlinux + rolling releases forever
close #19