Do not eagerly call next_uNN in fill_bytes with empty remainder
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where random numbers are consumed from the Mersenne Twister even when they will never be used because the remainder from the chunks iterator in `fill_bytes` is non-empty. This regression was introduced in: - #116 Add a basic smoke check for reproducibility with MRI's RNG pulled from `spinoso-random` in artichoke/artichoke.
lopopolo
added
A-core
|
v4.1.1 is released; v4.1.0 is yanked. $ cargo publish --dry-run
Updating crates.io index
Packaging rand_mt v4.1.1 (/Users/lopopolo/dev/artichoke/rand_mt)
Verifying rand_mt v4.1.1 (/Users/lopopolo/dev/artichoke/rand_mt)
Compiling rand_core v0.6.3
Compiling rand_mt v4.1.1 (/Users/lopopolo/dev/artichoke/rand_mt/target/package/rand_mt-4.1.1)
Finished dev [unoptimized + debuginfo] target(s) in 2.58s
Uploading rand_mt v4.1.1 (/Users/lopopolo/dev/artichoke/rand_mt)
warning: aborting upload due to dry run
$ cargo publish
Updating crates.io index
Packaging rand_mt v4.1.1 (/Users/lopopolo/dev/artichoke/rand_mt)
Verifying rand_mt v4.1.1 (/Users/lopopolo/dev/artichoke/rand_mt)
Compiling rand_core v0.6.3
Compiling rand_mt v4.1.1 (/Users/lopopolo/dev/artichoke/rand_mt/target/package/rand_mt-4.1.1)
Finished dev [unoptimized + debuginfo] target(s) in 1.44s
Uploading rand_mt v4.1.1 (/Users/lopopolo/dev/artichoke/rand_mt)
$ cargo yank --vers 4.1.0
Updating crates.io index
Yank rand_mt:4.1.0 |
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Dec 2, 2021
Pull in a bugfix for MRI reproducibility: - artichoke/rand_mt#122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where random numbers are consumed from the Mersenne Twister
even when they will never be used because the remainder from the chunks
iterator in
fill_bytesis non-empty.This regression was introduced in:
fill_byteswithchunks_exact_mut#116Add a basic smoke check for reproducibility with MRI's RNG pulled from
spinoso-randomin artichoke/artichoke.Prepare to release this change as v4.1.1 and yank v4.1.0.