Add reproducibility test for Mt::new_with_key
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
added
the
A-ruby
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Jun 26, 2022
MRI uses an `init_by_array` [0] function to initialize a `Random` instance with an arbitrarily-wide `Bignum` seed. [0] https://github.com/ruby/ruby/blob/v2_6_3/random.c#L373-L402 This requires exposing `Mt::new_with_key` from `rand_mt`. This patch makes a breaking change to `Random::with_array_seed` so that it accepts an `IntoIterator<Item = u32>`. Because `spinoso-random` can now have arbitarily wide keys, it stores the seed in a `Vec`, which means the crate now requires `alloc`. This patch does the minimum to get `artichoke-backend` working with these changes. Bump spinoso-random to 0.3.0. These changes match these from upstream `rand_mt`: - artichoke/rand_mt#145
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.