Add tests for boundary conditions when computing ISO week number #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
added
A-formatter
|
Hi @x-hgg-x, I tried to dig into the |
x-hgg-x
requested changes
Apr 2, 2023
|
Since you are testing multiple formatting specifiers at the same time, you must ensure that all fields of the |
|
It looks like that did the trick! Thanks for the help 🙇 |
x-hgg-x
approved these changes
Apr 2, 2023
|
Please remember to squash the commits and modify their description, since we didn't actually change any code. |
These tests were pulled from the following PR in chrono: - chronotope/chrono#966 Add a single test with these boundary condition dates. The dates were validated with MRI Ruby v3.1.2. The third test case differs between chrono and MRI, but since we target MRI, use it as the source of truth. No logic was changed as part of this commit, only additional tests were added. Co-authored-by: x-hgg-x <39058530+x-hgg-x@users.noreply.github.com>
lopopolo
force-pushed
the
lopopolo/iso-week-regression-tests
branch
from
7c9eed7
to
6d002a6
Compare
lopopolo
added
E-needs-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were pulled from the following PR in chrono:
Add a single test with these boundary condition dates. The dates were validated with MRI Ruby v3.1.2. The third test case differs between chrono and MRI, but since we target MRI, use it as the source of truth.
No logic was changed as part of this commit, only additional tests were added.