Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: don't load products and apps paths #143

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

mloberg
Copy link
Contributor

@mloberg mloberg commented May 26, 2023

These have been deprecated for a while and we've finally been able to move everything over to either services or global instead

BREAKING CHANGE: removes loading from deprecated paths

@mloberg mloberg requested a review from a team as a code owner May 26, 2023 14:04
@mloberg mloberg marked this pull request as draft May 26, 2023 14:05
These have been deprecated for a while and we've finally been able to
move everything over to either services or global instead

BREAKING CHANGE: removes loading from deprecated paths
@mloberg mloberg force-pushed the feature/remove-deprecated-paths branch from aa7ee67 to e8b4b44 Compare October 11, 2023 21:46
@mloberg mloberg marked this pull request as ready for review October 11, 2023 21:52
Copy link
Contributor

@dholmes dholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning a slack post and scheduled release? Or do you feel very confident that everyone has gotten off of these paths?

@mloberg
Copy link
Contributor Author

mloberg commented Oct 12, 2023

I'm pretty confident everything is migrated, but I'll make an internal announcement this morning. This won't go into our Docker images until tomorrow

@mloberg mloberg merged commit f46778b into main Oct 12, 2023
4 checks passed
@mloberg mloberg deleted the feature/remove-deprecated-paths branch October 12, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants