Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: if SERVICE_ENV is not set, default to dev #178

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

mloberg
Copy link
Contributor

@mloberg mloberg commented Oct 17, 2023

If environment is not set, it will try to load weird paths, which might not exist in Vault, so set this to a default with least privileges.

  • Make sure SERVICE_NAME is set as a lot of paths need that to work
  • Remove peer references as that's no longer a think
  • Rename package to docker-bootstrap to match repo name
  • Update to go 1.21

BREAKING CHANGE: will exit if SERVICE_NAME is not set

If an environment is not set, it will try to load weird paths, which
might not exist in Vault

Make sure SERVICE_NAME is set as a lot of paths need that to work

Remove peer references as that's no longer a think

BREAKING CHANGE: will exit if SERVICE_NAME is not set
@mloberg mloberg marked this pull request as ready for review October 17, 2023 12:49
@mloberg mloberg requested a review from a team as a code owner October 17, 2023 12:49
Update references to the new package name.

Update to go 1.21
@mloberg mloberg force-pushed the feature/default-env-dev branch from 6c6d3c9 to ac1c521 Compare October 17, 2023 12:51
Copy link
Contributor

@Dbaker1298 Dbaker1298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the explanation. LGTM

@mloberg mloberg merged commit 3893476 into main Oct 17, 2023
3 checks passed
@mloberg mloberg deleted the feature/default-env-dev branch October 17, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants