Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward signals to child process #207

Merged
merged 2 commits into from
May 10, 2024
Merged

fix: forward signals to child process #207

merged 2 commits into from
May 10, 2024

Conversation

mloberg
Copy link
Contributor

@mloberg mloberg commented May 10, 2024

Applications are expecting to get SIGTERM to handle any shutdown. This currently doesn't forward signals and will just terminate the child process.

@mloberg mloberg marked this pull request as ready for review May 10, 2024 14:09
@mloberg mloberg requested a review from a team May 10, 2024 14:09
dholmes
dholmes previously approved these changes May 10, 2024
Copy link
Contributor

@dholmes dholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work and super-fast turnaround. Thank you Matt!

main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tecnobrat tecnobrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the termwait timeout needs to be increased.

mloberg added 2 commits May 10, 2024 14:46
Applications are expecting to get SIGTERM to handle any shutdown. This
currently doesn't forward signals and will just terminate the child
process.
The team name has changed recently
@mloberg mloberg merged commit 4978d3f into main May 10, 2024
3 checks passed
@mloberg mloberg deleted the fix/handle-signals branch May 10, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants