Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validate): include missing env vars in error message #213

Merged
merged 1 commit into from
May 16, 2024

Conversation

mloberg
Copy link
Contributor

@mloberg mloberg commented May 16, 2024

When missing require env vars, the final error message doesn't include any indication of what's missing. We do log in another line the list, but has lead to confusion when debugging

When missing require env vars, the final error message doesn't include
any indication of what's missing. We do log in another line the list,
but has lead to confusion when debugging
@mloberg mloberg marked this pull request as ready for review May 16, 2024 18:53
@mloberg mloberg requested a review from a team as a code owner May 16, 2024 18:53
@mloberg mloberg merged commit c312e21 into main May 16, 2024
3 checks passed
@mloberg mloberg deleted the fix/confusing-exit-message branch May 16, 2024 18:54
Copy link
Contributor

@gsporterfield gsporterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest adding docker-bootstrap into the message text (or another json field) just so it's clear who is emitting this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants