WIP - mysql stream #521
Draft
WIP - mysql stream #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-artie
commented
Nov 14, 2024
| @@ -6,3 +6,4 @@ services: | |||
| MYSQL_ROOT_PASSWORD: mysql | |||
| ports: | |||
| - 3306:3306 | |||
| command: --binlog-row-metadata=FULL | |||
There was a problem hiding this comment.
This makes it so that in the binlog change events we get all the column names. Without this the column names are empty.
nathan-artie
commented
Nov 14, 2024
| } | ||
|
|
||
| func (s *StreamingSource) Run(ctx context.Context, writer writers.Writer) error { | ||
| streamer, err := s.syncer.StartSync(mysql.Position{}) |
There was a problem hiding this comment.
If we want offsets this is where we would pass them in.
nathan-artie
commented
Nov 14, 2024
| return fmt.Errorf("unable to cast event to replication.RowsEvent") | ||
| } | ||
|
|
||
| if string(rowsEvent.Table.Table) != "foo" { |
There was a problem hiding this comment.
I was testing with a local table named foo, this is where we need to filter for the tables we care about.
nathan-artie
commented
Nov 14, 2024
| slog.Error("Failed to convert event to messages", slog.Any("err", err)) | ||
| } else { | ||
| for i, message := range messages { | ||
| slog.Info("messages", slog.Int("index", i), slog.Any("event", message.Event())) |
There was a problem hiding this comment.
Emit the messages to Kafka.
nathan-artie
commented
Nov 14, 2024
| } | ||
|
|
||
| collationMap := event.Table.CollationMap() | ||
| dataTypes := make([]schema.DataType, len(event.Table.ColumnType)) |
There was a problem hiding this comment.
This is mapping to the data types that we use for backfilling, we may not want to do this though and build our own list of converters.
nathan-artie
commented
Nov 14, 2024
| @@ -88,7 +88,7 @@ func (m MySQLAdapter) PartitionKeys() []string { | |||
| return m.table.PrimaryKeys | |||
| } | |||
|
|
|||
| func valueConverterForType(d schema.DataType, opts *schema.Opts) (converters.ValueConverter, error) { | |||
| func ValueConverterForType(d schema.DataType, opts *schema.Opts) (converters.ValueConverter, error) { | |||
There was a problem hiding this comment.
We probably don't want to share these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.