fix: parsing for non-english systems, part 2 #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24 didn't fully fix the problem with parsing on non-English systems.
isPrintComplete
requires that bothprint
and its ownlpstat
outputs English, otherwise the parsing fails and it will always return false.In fact,
execAsync
always needs to output English, so instead of addingSOFTWARE= LANG=C
to each command in the codebase, I rewroteexecAsync
so that it always adds the environment variables there. Is this an okay change, or do you plan on usingexecAsync
for other purposes where the variables aren't needed?PS. I changed the type definition for
ExecResponse
, sincestdout
andstderr
should never be null. The code mostly ignores the possible null anyway, andnpm build:declarations
would throw a bunch of errors before this change.