Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): support nodeSelector for workloads #3574

Merged
merged 3 commits into from
Jan 8, 2024
Merged

feat(chart): support nodeSelector for workloads #3574

merged 3 commits into from
Jan 8, 2024

Conversation

jking916
Copy link
Contributor

@jking916 jking916 commented Jan 4, 2024

Currently there is no way in the Helm chart to configure Artifact Hub to run on specific nodes in a Kubernetes cluster. This PR adds support for node selectors for each workload (the postgres chart already supports this).

Copy link
Collaborator

@tegioz tegioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jking916!

Could you please bump the chart version to 1.16.1-4 and rebase from master?

Signed-off-by: Jared King <jared.king@subsplash.com>
Signed-off-by: Jared King <jared.king@subsplash.com>
Signed-off-by: Jared King <jared.king@subsplash.com>
@jking916
Copy link
Contributor Author

jking916 commented Jan 8, 2024

Done. Thanks for reviewing @tegioz!

Copy link
Collaborator

@tegioz tegioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tegioz tegioz merged commit e7c3de9 into artifacthub:master Jan 8, 2024
13 checks passed
@jking916 jking916 deleted the feat-chart-nodeselector branch January 8, 2024 19:22
@jking916
Copy link
Contributor Author

jking916 commented Jan 9, 2024

When can we expect a new chart version to be released? Is that done separately from Artifact Hub itself?

@tegioz
Copy link
Collaborator

tegioz commented Jan 10, 2024

I think we'll probably cut a new release next week.

@jking916
Copy link
Contributor Author

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants