Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create repository page should provide to fill all information in single form #112

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

andpopov
Copy link
Member

@andpopov andpopov commented Nov 7, 2022

No description provided.

@andpopov
Copy link
Member Author

andpopov commented Nov 7, 2022

Part of: #101
@olenagerasimova Please review

Copy link
Member

@olenagerasimova olenagerasimova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andpopov thanks, code looks ok, but I have some comments about UI:

  1. Repo usage info formatting sometimes looks off

image

  1. when repo is created, the name can not be entered yet and in this case repo usage info is not fully correct (as repository name is missing). I'm not even sure how to deal with this case, but it may be misleading

For now, these issues can be ignored, but we should definitely deal with them later

@andpopov andpopov merged commit bca22fd into artipie:master Nov 7, 2022
@andpopov andpopov deleted the create_repo branch November 8, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants