Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert grid corner < CLIGHT not needed with FORCE_SPHERICAL_ESCAPE_SU… #57

Merged
merged 2 commits into from
May 15, 2024
Merged

Assert grid corner < CLIGHT not needed with FORCE_SPHERICAL_ESCAPE_SU… #57

merged 2 commits into from
May 15, 2024

Conversation

ccollins22
Copy link
Member

…RFACE

@ccollins22 ccollins22 requested a review from lukeshingles May 15, 2024 08:46
lukeshingles
lukeshingles requested changes May 15, 2024
View reviewed changes
Copy link
Member

@lukeshingles lukeshingles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your clang format check failure (pre-commit should have caught this?) and target the develop branch, and then it looks ready to merge.

@lukeshingles lukeshingles changed the base branch from main to develop May 15, 2024 09:26
@lukeshingles lukeshingles merged commit f88b5b4 into develop May 15, 2024
54 checks passed
@lukeshingles lukeshingles deleted the ccollins22-patch-1 branch May 15, 2024 09:42
lukeshingles pushed a commit that referenced this pull request May 15, 2024
@ccollins22 @lukeshingles
Assert grid corner < CLIGHT not needed with FORCE_SPHERICAL_ESCAPE_SU…
d64aae6 
…RFACE (#57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeshingles lukeshingles lukeshingles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccollins22 @lukeshingles