Fix major issues in classic mode for deflagration model #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeshingles
changed the title
lukeshingles
force-pushed
the
develop_fixclassic_closesttransition
branch
from
5a9b047 to
c247f82
Compare
lukeshingles
changed the title
lukeshingles
force-pushed
the
develop_fixclassic_closesttransition
branch
2 times, most recently
from
f36165a to
c9fe8a1
Compare
lukeshingles
force-pushed
the
develop_fixclassic_closesttransition
branch
from
beb6043 to
d4a2dde
Compare
lukeshingles
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major slowdown and strange bolometric light curve found for r10_d2.6_Z deflagration model in classic mode by @fionntancallan. The exact cause is unknown, but some combination of: thread_local storage of continuum opacities gnu::const/pure attributes, re-use of continuum opacities for similar nu_cmf, or not updating cellcache on thick cells.