Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160233942 Add feature to update food order status #4

Merged

Conversation

artorious
Copy link
Owner

What does this PR do?

  • Updates a food order matching the provided orderID

Description of Task to be completed?

  • Creates and tests an RESTful API endpoint
    PUT /api/v1/orders/<orderID>

How the app should be tested

  • Set Install, setup and configure the development enviroment.
  1. Install python3

  2. Pipenv & Virtual Environments

  3. On a terminal (Linux), Install and set up git sudo apt install git

  4. Clone the repository git clone https://github.com/artorious/speedy_chakula_app.git

  5. Run cd speedy_chakula_app/

  6. Run git checkout ft-update-food-order-160233942

  7. In a virutal environment, run pipenv shell to install requirements

  8. Test the code coverage run -m pytest -v app/tests/test* ; coverage report app/tests/test_* app/*.py

  9. run FLASK_APP=run.py ; flask run

  10. Test endpoint on Postman

Any background context you want to provide?

API endpoint uses data structures to store data in memory

What are the relevant pivotal tracker stories?

Failing unit Tests
Passing unit Tests

Screenshots

screenshot from 2018-09-07 11-27-49
screenshot from 2018-09-07 11-37-09
screenshot from 2018-09-07 11-37-35
screenshot from 2018-09-07 11-37-44
screenshot from 2018-09-07 11-38-21
screenshot from 2018-09-07 11-38-37
screenshot from 2018-09-07 11-38-47
screenshot from 2018-09-07 11-39-09

Questions:

Failing unit tests to FETCH A SINGLE ORDER
@jeffnyalik
Copy link

Nice one, just noted are you using unittest for the application.

@Kalela
Copy link

Kalela commented Sep 24, 2018

I think you can put the Pipfile.lock in your .gitignore. What do you think?

@artorious
Copy link
Owner Author

I think you can put the Pipfile.lock in your .gitignore. What do you think?

Hi, I've been thinking on that myself. Following the discussion on the same issue in pypa/pipenv#598 it seems that tracking the pipfile is recomended. Pls Advise....

@Kalela
Copy link

Kalela commented Sep 25, 2018

I think it's fine having it there. We can always remove it later on if it causes any trouble.

@Kalela
Copy link

Kalela commented Sep 25, 2018

LGTM. I'm merging this now.

@Kalela Kalela merged commit 3072c20 into ep-dev-api-endpoints-v1-##4065656 Sep 25, 2018
@artorious artorious deleted the ft-update-food-order-160233942 branch October 24, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants