add explicit empty fallback for home view sections

artsy · Oct 3, 2024 · 20f464a · 20f464a
1 parent 7e3870b
commit 20f464a
Show file tree

Hide file tree

Showing 14 changed files with 203 additions and 147 deletions.
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionActivity.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionActivity.tsx
@@ -187,14 +187,18 @@ const HomeViewSectionActivityPlaceholder: React.FC = () => {
 
 export const HomeViewSectionActivityQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionActivityQuery>(homeViewSectionActivityQuery, {
-    id: props.sectionID,
-  })
-
-  if (!data.homeView.section) {
-    return null
-  }
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionActivityQuery>(homeViewSectionActivityQuery, {
+      id: props.sectionID,
+    })
+
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionActivity section={data.homeView.section} />
-}, HomeViewSectionActivityPlaceholder)
+    return <HomeViewSectionActivity section={data.homeView.section} />
+  },
+  HomeViewSectionActivityPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionArticles.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionArticles.tsx
@@ -124,14 +124,18 @@ const HomeViewSectionArticlesPlaceholder: React.FC = () => {
 
 export const HomeViewSectionArticlesQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionArticlesQuery>(homeViewSectionArticlesQuery, {
-    id: props.sectionID,
-  })
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionArticlesQuery>(homeViewSectionArticlesQuery, {
+      id: props.sectionID,
+    })
 
-  if (!data.homeView.section) {
-    return null
-  }
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionArticles section={data.homeView.section} />
-}, HomeViewSectionArticlesPlaceholder)
+    return <HomeViewSectionArticles section={data.homeView.section} />
+  },
+  HomeViewSectionArticlesPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionArticlesCards.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionArticlesCards.tsx
@@ -172,17 +172,21 @@ const homeViewSectionArticlesCardsQuery = graphql`
 
 export const HomeViewSectionArticlesCardsQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionArticlesCardsQuery>(
-    homeViewSectionArticlesCardsQuery,
-    {
-      id: props.sectionID,
-    }
-  )
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionArticlesCardsQuery>(
+      homeViewSectionArticlesCardsQuery,
+      {
+        id: props.sectionID,
+      }
+    )
 
-  if (!data.homeView.section) {
-    return null
-  }
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionArticlesCards section={data.homeView.section} />
-}, HomeViewSectionArticlesCardsPlaceholder)
+    return <HomeViewSectionArticlesCards section={data.homeView.section} />
+  },
+  HomeViewSectionArticlesCardsPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionArtists.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionArtists.tsx
@@ -238,14 +238,18 @@ const HomeViewSectionArtistsPlaceholder: React.FC = () => {
 
 export const HomeViewSectionArtistsQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionArtistsMainQuery>(homeViewSectionArtistsQuery, {
-    id: props.sectionID,
-  })
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionArtistsMainQuery>(homeViewSectionArtistsQuery, {
+      id: props.sectionID,
+    })
 
-  if (!data.homeView.section) {
-    return null
-  }
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionArtistsPaginationContainer section={data.homeView.section} />
-}, HomeViewSectionArtistsPlaceholder)
+    return <HomeViewSectionArtistsPaginationContainer section={data.homeView.section} />
+  },
+  HomeViewSectionArtistsPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionArtworks.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionArtworks.tsx
@@ -159,14 +159,18 @@ const HomeViewSectionArtworksPlaceholder: React.FC = () => {
 
 export const HomeViewSectionArtworksQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionArtworksQuery>(homeViewSectionArtworksQuery, {
-    id: props.sectionID,
-  })
-
-  if (!data.homeView.section) {
-    return null
-  }
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionArtworksQuery>(homeViewSectionArtworksQuery, {
+      id: props.sectionID,
+    })
+
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionArtworks section={data.homeView.section} />
-}, HomeViewSectionArtworksPlaceholder)
+    return <HomeViewSectionArtworks section={data.homeView.section} />
+  },
+  HomeViewSectionArtworksPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionAuctionResults.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionAuctionResults.tsx
@@ -189,17 +189,21 @@ const homeViewSectionAuctionResultsQuery = graphql`
 
 export const HomeViewSectionAuctionResultsQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionAuctionResultsQuery>(
-    homeViewSectionAuctionResultsQuery,
-    {
-      id: props.sectionID,
-    }
-  )
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionAuctionResultsQuery>(
+      homeViewSectionAuctionResultsQuery,
+      {
+        id: props.sectionID,
+      }
+    )
 
-  if (!data.homeView.section) {
-    return null
-  }
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionAuctionResults section={data.homeView.section} />
-}, HomeViewSectionAuctionResultsPlaceholder)
+    return <HomeViewSectionAuctionResults section={data.homeView.section} />
+  },
+  HomeViewSectionAuctionResultsPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionFairs.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionFairs.tsx
@@ -176,14 +176,18 @@ const homeViewSectionFairsQuery = graphql`
 
 export const HomeViewSectionFairsQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionFairsQuery>(homeViewSectionFairsQuery, {
-    id: props.sectionID,
-  })
-
-  if (!data.homeView.section) {
-    return null
-  }
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionFairsQuery>(homeViewSectionFairsQuery, {
+      id: props.sectionID,
+    })
+
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionFairs section={data.homeView.section} />
-}, HomeViewSectionFairsPlaceholder)
+    return <HomeViewSectionFairs section={data.homeView.section} />
+  },
+  HomeViewSectionFairsPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionFeaturedCollection.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionFeaturedCollection.tsx
@@ -179,17 +179,21 @@ const homeViewSectionFeaturedCollectionQuery = graphql`
 
 export const HomeViewSectionFeaturedCollectionQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionFeaturedCollectionQuery>(
-    homeViewSectionFeaturedCollectionQuery,
-    {
-      id: props.sectionID,
-    }
-  )
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionFeaturedCollectionQuery>(
+      homeViewSectionFeaturedCollectionQuery,
+      {
+        id: props.sectionID,
+      }
+    )
 
-  if (!data.homeView.section) {
-    return null
-  }
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionFeaturedCollection section={data.homeView.section} />
-}, HomeViewSectionFeaturedCollectionPlaceholder)
+    return <HomeViewSectionFeaturedCollection section={data.homeView.section} />
+  },
+  HomeViewSectionFeaturedCollectionPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionGalleries.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionGalleries.tsx
@@ -146,14 +146,18 @@ const homeViewSectionGalleriesQuery = graphql`
 
 export const HomeViewSectionGalleriesQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionGalleriesQuery>(homeViewSectionGalleriesQuery, {
-    id: props.sectionID,
-  })
-
-  if (!data.homeView.section) {
-    return null
-  }
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionGalleriesQuery>(homeViewSectionGalleriesQuery, {
+      id: props.sectionID,
+    })
+
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionGalleries section={data.homeView.section} />
-}, HomeViewSectionGalleriesPlaceholder)
+    return <HomeViewSectionGalleries section={data.homeView.section} />
+  },
+  HomeViewSectionGalleriesPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionHeroUnits.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionHeroUnits.tsx
@@ -131,14 +131,18 @@ const homeViewSectionHeroUnitsQuery = graphql`
 
 export const HomeViewSectionHeroUnitsQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionHeroUnitsQuery>(homeViewSectionHeroUnitsQuery, {
-    id: props.sectionID,
-  })
-
-  if (!data.homeView.section) {
-    return null
-  }
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionHeroUnitsQuery>(homeViewSectionHeroUnitsQuery, {
+      id: props.sectionID,
+    })
+
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionHeroUnits section={data.homeView.section} />
-}, HomeViewSectionHeroUnitsPlaceholder)
+    return <HomeViewSectionHeroUnits section={data.homeView.section} />
+  },
+  HomeViewSectionHeroUnitsPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionMarketingCollections.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionMarketingCollections.tsx
@@ -213,17 +213,21 @@ const homeViewSectionMarketingCollectionsQuery = graphql`
 
 export const HomeViewSectionMarketingCollectionsQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionMarketingCollectionsQuery>(
-    homeViewSectionMarketingCollectionsQuery,
-    {
-      id: props.sectionID,
-    }
-  )
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionMarketingCollectionsQuery>(
+      homeViewSectionMarketingCollectionsQuery,
+      {
+        id: props.sectionID,
+      }
+    )
 
-  if (!data.homeView.section) {
-    return null
-  }
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionMarketingCollections section={data.homeView.section} />
-}, HomeViewSectionMarketingCollectionsPlaceholder)
+    return <HomeViewSectionMarketingCollections section={data.homeView.section} />
+  },
+  HomeViewSectionMarketingCollectionsPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionSales.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionSales.tsx
@@ -192,14 +192,18 @@ const homeViewSectionSalesQuery = graphql`
 
 export const HomeViewSectionSalesQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionSalesQuery>(homeViewSectionSalesQuery, {
-    id: props.sectionID,
-  })
-
-  if (!data.homeView.section) {
-    return null
-  }
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionSalesQuery>(homeViewSectionSalesQuery, {
+      id: props.sectionID,
+    })
+
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionSales section={data.homeView.section} />
-}, HomeViewSectionSalesPlaceholder)
+    return <HomeViewSectionSales section={data.homeView.section} />
+  },
+  HomeViewSectionSalesPlaceholder,
+  undefined
+)
diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionShows.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionShows.tsx
@@ -70,14 +70,18 @@ const homeViewSectionShowsQuery = graphql`
 
 export const HomeViewSectionShowsQueryRenderer: React.FC<{
   sectionID: string
-}> = withSuspense((props) => {
-  const data = useLazyLoadQuery<HomeViewSectionShowsQuery>(homeViewSectionShowsQuery, {
-    id: props.sectionID,
-  })
+}> = withSuspense(
+  (props) => {
+    const data = useLazyLoadQuery<HomeViewSectionShowsQuery>(homeViewSectionShowsQuery, {
+      id: props.sectionID,
+    })
 
-  if (!data.homeView.section) {
-    return null
-  }
+    if (!data.homeView.section) {
+      return null
+    }
 
-  return <HomeViewSectionShows section={data.homeView.section} />
-}, HomeViewSectionShowsPlaceholder)
+    return <HomeViewSectionShows section={data.homeView.section} />
+  },
+  HomeViewSectionShowsPlaceholder,
+  undefined
+)