Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add get current route helper #10199

Closed
wants to merge 1 commit into from

Conversation

MounirDhahri
Copy link
Member

This PR resolves []

Description

This PR adds a helper method to get the active URL - ready to share.
I needed to do this manually because 1. useLinkBuilder from react-navigation doesn't work in our infra and 2. doesn't support the nested routes we use (AFAIK).

I needed this to work on a future Friday project that unfortunately didn't work out well. I created this PR to save a future me or other engineer in Artsy the time and hassle that was required to build this.

@brainbicycle I know you are working on some navigation stuff, this might be useful to you - who knows

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add get current route helper - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant