Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove sub-copy from Artwork Saved tooltip for auction lots #10500

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

oxaudo
Copy link
Member

@oxaudo oxaudo commented Jul 18, 2024

This PR resolves https://artsyproduct.atlassian.net/browse/EMI-1976

My first PR in Eigen so please excuse my mistakes here. Figuring out this Eigen flow!

Description

Ideally we would have the auction saves(watches) go into a different list type but that is not done this way now. We are relying on checking if the artwork is in the auction for handling those saves in several places. So for now just reading this attribute from artwork and basing the sub-copy on that parameter.

Before:
Screen Shot 2024-07-18 at 11 53 15 AM

After:
Screen Shot 2024-07-18 at 11 53 00 AM

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Removed misleading sub-note after auction artwork save - oxaudo

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@oxaudo oxaudo self-assigned this Jul 18, 2024
@oxaudo oxaudo changed the title Chore: Remove sub-copy from Artwork Saved tooltip for auction lots chore: Remove sub-copy from Artwork Saved tooltip for auction lots Jul 18, 2024
Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 congrats on your first Eigen PR, the changes look reasonable to me.

Meta: on pr checklist for the checkboxes you should just fill with an x like so [x] or not fill instead of yes or na, for the changelog, you should add a line describing your changes to the applicable section in this case that would be Cross platform user facing changes and could be something like: remove subcopy for artwork save tooltip in auction lots - oxaudo

Edit: went ahead and updated but let me know if anything unclear!

@artsy artsy deleted a comment from ArtsyOpenSource Jul 18, 2024
@oxaudo oxaudo merged commit 27c37c8 into main Jul 18, 2024
7 checks passed
@oxaudo oxaudo deleted the oxaudo/notte branch July 18, 2024 19:23
@oxaudo
Copy link
Member Author

oxaudo commented Jul 18, 2024

Thanks for the review @brainbicycle! Merged it.

iskounen pushed a commit that referenced this pull request Jul 19, 2024
chore: Remove sub-copy from Artwork Saved tooltip for auction lots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants