feat(home view): support a singular Card section and deprecate the current Galleries section component #10922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section type was a bit of a misnomer and never actually served up a galleries connection. We remove it here, with the possibility of bring it back such a component when it is actually needed
anandaroop
force-pushed
the
anandaroop/ONYX-1350-single-card
branch
from
92fbc3f
to
4abed47
Compare
|
Had to adjust for #10824 but all good now, merging… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1350
Description
Note
Counterpart of artsy/metaphysics#6116
See that^ description for motivation and caveats.
Visually and functionally there is no change here, but under the hood we have retired the misnamed
HomeViewSectionGalleriesin favor of the newHomeViewSectionCard:PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.