Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ExploreBy): address bugs, layout issues and relay fetching issues #11008

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

araujobarret
Copy link
Contributor

Description

  • replaces useClientQuery with useLazyLoadQuery
  • adds FlashList for performance optimization of the collection list of rails
  • adds missing UI elements such as Dividers
  • fix the navigation bug from the collection rail, now navigates when tapping on artworks or in the title
  • few Chriss' requests about relay variable naming and use of plural
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-10-24.at.10.18.04.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • refactor: address bugs, layout issues, and relay fetching bugs of collections by category work

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@araujobarret araujobarret requested a review from a team October 24, 2024 08:41
@araujobarret araujobarret self-assigned this Oct 24, 2024
marketingCollections(category: $category, first: 20) {
...BodyCollectionsByCategory_marketingCollection
...CollectionsChips_marketingCollections
query BodyCollectionsByCategoryQuery($category: String!) @cacheable {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeyAghion added the @cacheable here since, in this first part we have no custom-user-data being fetched, we only use to display the chips collections list and to get each collection slug.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Oct 24, 2024

This PR contains the following changes:

  • Cross-platform user-facing changes (refactor: address bugs, layout issues, and relay fetching bugs of collections by category work - araujobarret)

Generated by 🚫 dangerJS against e8149e3

@araujobarret
Copy link
Contributor Author

Gonna merge it in order to prepare for the QA, will address further request in follow-up PRs 👍

@araujobarret araujobarret merged commit 62145d1 into main Oct 24, 2024
7 checks passed
@araujobarret araujobarret deleted the araujobarret/fix/broken-links-collections-misc branch October 24, 2024 09:36
@araujobarret araujobarret changed the title feat(ExploreBy): address bugs, layout issues and relay fetching bugs feat(ExploreBy): address bugs, layout issues and relay fetching issues Oct 24, 2024
})

if (!data.marketingCollections) {
const data = useLazyLoadQuery<BodyCollectionsByCategoryQuery>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants