feat: Long-press artwork context menu for Android #11359
+191
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
changed the title
olerichter00
force-pushed
the
olerichter00/ONYX-1474/long-press-artwork-context-menu-for-android
branch
from
87895ca to
c44814b
Compare
olerichter00
commented
Jan 24, 2025
Comment on lines
+95
to
+96
| <Box pr={2}> | ||
| <RouterLink |
There was a problem hiding this comment.
Moving ContextMenuArtwork inside RouterLink so RouterLink's onPress still works.
olerichter00
changed the title
olerichter00
commented
Jan 24, 2025
| `, | ||
| }) | ||
|
|
||
| describe("on Android", () => { |
There was a problem hiding this comment.
I was not able to test the context menu on iOS with react-native-context-menu-view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1474
Description
This implements the Artwork card long-press context menu for Android using a bottom sheet.
AREnableArtworkCardContextMenuAndroidScreenshots
Android
iOS
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.