chore(ONYX-344): retire AREnableArtworksConnectionForAuction feature flag #11370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a8d66a2.
…-for-auction-echo-flag' into dariakoko/retire-AREnableArtworksConnectionForAuction
MounirDhahri
previously approved these changes
Jan 21, 2025
| displayText: "Lot Number Ascending", | ||
| paramName: FilterParamName.sort, | ||
| paramValue: "sale_position", | ||
| paramValue: "position", |
There was a problem hiding this comment.
do we intentionally want to change the default value?
There was a problem hiding this comment.
Nope, thanks for spotting, changed it back to sale_position
| onApply: () => scrollToTop(), | ||
| }) | ||
|
|
||
| if (totalCount === 0) { |
There was a problem hiding this comment.
this used to be broken in the past 👀 - glad it's fixed now.
There was a problem hiding this comment.
What was broken exactly?
artsyit
dismissed stale reviews from olerichter00 and MounirDhahri
via
8507a9a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-344
Description
Retire AREnableArtworksConnectionForAuction feature flag
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.