Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
tipsi-stripe
to my fork, which includes this commit (copied from this PR that was closed without resolution) which fixes this bug. The bug appears related to our recent React Native upgrade (I ruled out thetipsi-stripe
upgrade from 7.4.0 -> 7.5.0).The fix was to remove a callback for when the keyboard appears; the callback that was being executed was this:
Which reads: "if the request to become a first respond (focus the text field) doesn't come from JS and if I am not the first responder (I have the keyboard focus) then make sure that the payment card text field subview loses focus."
I've looked through the git history to figure out the purpose of this code, but it's unclear. My guess is it has to do with supporting credit card inputs in a larger form with other inputs. Our UI has just the credit card input on screen at a time (no other text inputs) so the only way the keyboard shows is if if the
_paymentCardTextField
has been tapped by the user and is becoming the responder. Because the code only ever makes the payment field resign first responder and is only ever invoked when the payment field becomes the first responder, I am comfortable shipping this. (This also explains the crash we're seeing: stack overflow from infinite show-and-hide-and-show-etc the keyboard.)Please let me know what I can clarify. I've verified this works as expected on device by going through the complete bid -> register flow successfully (well, I didn't meet the reserve, but the bid did go through).
I will follow-up on the PR to ask why it was closed and will follow-up here.