[WIP]feat: add react native testing library #5132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
commented
Jul 15, 2021
| @@ -40,7 +41,7 @@ describe(ArtsyReactWebViewPage, () => { | |||
| it("shares the correct URL", () => { | |||
| const tree = render({ showShareButton: true }) | |||
| tree.root.findByType(FancyModalHeader).props.onRightButtonPress() | |||
| setTimeout(() => expect(jest.fn()).toHaveBeenCalledWith()) | |||
| waitFor(() => expect(jest.fn()).toHaveBeenCalledTimes(1)) | |||
There was a problem hiding this comment.
So here when adding @testing-library/react-native setTimeouts like this were breaking. I am not sure if it is the BEST approach to use waitFor from @testing-library/react-native in tests that are not written with this library.
What do you think?
Comment on lines
-167
to
-172
| beforeAll(() => { | ||
| jest.useFakeTimers() | ||
| }) | ||
| afterAll(() => { | ||
| jest.useRealTimers() | ||
| }) |
There was a problem hiding this comment.
Removed the timers since with waitFor we don't actually need them.
src/lib/tests/renderWithWrappers.tsx
Outdated
| import { ReactElement } from "simple-markdown" | ||
|
|
||
| export const Wrappers: React.FC = ({ children }) => { | ||
| return ( | ||
| // <RelayEnvironmentProvider environment={defaultEnvironment}> |
There was a problem hiding this comment.
Do we actually want this here? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Enhancement
This PR resolves []
@pvinis
Description
Another thing that is worth mentioning here is that the version is one minor release behind the latest cause of this issue fixed in this PR but not yet released.
ProblemsThe problem at the moment is that 4 tests are failing more specifically:OrderDetails-tests.tsxRegistrationFlow-tests.tsxMyBids-tests.tsxConsignments/tests/index-tests.tsx~~Reason: ~~
Failed: "TypeError: Cannot read property '_responseForQueryIDWithVariables' of undefined"Failed: "TypeError: Cannot read property '_setResponseForQueryIDWithVariables' of undefined"These two come from the following:Artsy/eigen/src/lib/NativeModules/GraphQLQueryCache.tsArtsy/eigen/emission/Pod/Classes/GraphQL/ARGraphQLQueryCache.mThe above where solved when added these lines to mock
createEnvironmentto setupJest.ts.PR Checklist (tick all before merging)
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes