Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CX-3186): add images gallery to android #7737

Merged
merged 7 commits into from
Nov 29, 2022

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Nov 25, 2022

This PR resolves CX-3186

Description

This PR adds the images gallery to android

Still to do (not blocker for reviewing the PR):

  • Implement deep zoom on zoom begin 👀
  • Draft a small RFC about package choice
Screen_Recording_20221128_131611_Artsy.mp4

PR Checklist

  • I tested my changes on iOS / Android.
  • I added screenshots or videos to illustrate my changes.
  • I added Tests and Stories for my changes.
  • I added an app state migration.
  • I hid my changes behind a feature flag.
  • I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Nov 25, 2022
@MounirDhahri MounirDhahri force-pushed the feat/add-image-gallery-to-android branch from 1741f38 to 3ca8d45 Compare November 28, 2022 12:37
@MounirDhahri MounirDhahri force-pushed the feat/add-image-gallery-to-android branch from 3ca8d45 to 73b29ef Compare November 29, 2022 10:43
Copy link
Contributor

@lordkiz lordkiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me.
Your latest commits fixed what I was going to comment on.
Looks reallyyyy good 🎉

@MounirDhahri MounirDhahri merged commit 3c7b74f into main Nov 29, 2022
@MounirDhahri MounirDhahri deleted the feat/add-image-gallery-to-android branch November 29, 2022 16:58
@fukemy
Copy link

fukemy commented Dec 26, 2023

hi, can u provide swipe down to close function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants