-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: problematic android infinite scroll grids #9013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those 💚
I wonder if we have any other infinite scrolls layout impacted by the bug that we might be missing but we can address them in follow-up PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix George!! 🚀🚀🚀
@araujobarret This is how I searched for all affected other surfaces: The problem is when you have a Searched for references of Feel free to also check in case I missed anything |
Actually I did miss some while rechecking @araujobarret :P following up with a commit |
@araujobarret I didn't miss any in the end, they were some of them that had the |
Awesome, thanks for the extra care! |
Thanks George 🙏 |
This PR resolves PHIRE-100
Description
There was a report that after migrating to collapsible-tabs from stickyTabs the infinite scrolling stopped working on Android.
The issue was that we use infiniteScrollArtworkGrid in these surfaces that uses a different implementation (scrollview) for iOS and (ParentAwareScrollView) on Android.
Wrapping it to another scrollview broke the functionality, this PR fixes this behavior on the following ArtworkGrids:
Let me know if you have any concerns, will add a test case for that on the sprintly mobile QA tomorrow to test it out thouroughly.
Videos
Screen.Recording.2023-07-20.at.10.47.48.mov
Screen.Recording.2023-07-20.at.10.46.52.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.