Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ONYX-150): use myCollectionConnection to fetch artworks count within my collection #9027

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Jul 20, 2023

This PR resolves ONYX-150

Description

This PR updates the logic in the artists preview bottom sheet to use myCollectionConnection to fetch artworks count within my collection

Screen.Recording.2023-07-20.at.17.30.13.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • use myCollectionConnection to fetch artworks count within my collection - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jul 20, 2023

This PR contains the following changes:

  • Cross-platform user-facing changes (use myCollectionConnection to fetch artworks count within my collection - mounir)

Generated by 🚫 dangerJS against ea84ad7

dariakoko
dariakoko previously approved these changes Jul 20, 2023
olerichter00
olerichter00 previously approved these changes Jul 20, 2023
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@olerichter00 olerichter00 added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Jul 20, 2023
@MounirDhahri MounirDhahri dismissed stale reviews from olerichter00 and dariakoko via ea84ad7 July 20, 2023 16:03
@MounirDhahri MounirDhahri force-pushed the chore/use-my-collection-connection-artworks-count branch from 186993c to ea84ad7 Compare July 20, 2023 16:03
@artsy-peril artsy-peril bot merged commit 2c88d07 into main Jul 20, 2023
@artsy-peril artsy-peril bot deleted the chore/use-my-collection-connection-artworks-count branch July 20, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants