(wip - don't merge) : build: codepush sdk #9137
Conversation
Co-authored-by: George <g.kartalis7@gmail.com>
| @@ -36,7 +36,7 @@ | |||
| <key>CFBundlePackageType</key> | |||
| <string>APPL</string> | |||
| <key>CFBundleShortVersionString</key> | |||
| <string>7.3.6</string> | |||
| <string>8.18.0</string> | |||
There was a problem hiding this comment.
need to start updating the version number in the project so codepush, codepush reads from the plist, can potentially override but think we can update the script we run in release process to update everywhere
| deploymentKey: Config.CODE_PUSH_STAGING_DEPLOYMENT_KEY, | ||
| checkFrequency: codePush.CheckFrequency.MANUAL, | ||
| } | ||
| : { deploymentKey: Config.CODE_PUSH_PRODUCTION_DEPLOYMENT_KEY } |
There was a problem hiding this comment.
(blocking) Can we move this system-y setup code into app/system/codepush.ts so that it is discoverable?
There was a problem hiding this comment.
you mean just the options? sure, can do that
There was a problem hiding this comment.
Yep, this block that configures codepush; we can import it from system and apply it to App here in the root
brainbicycle
changed the title
| calculated_hash=$("$DIR/calculate-native-hash.sh") | ||
|
|
||
| # Retrieve the current native code version from app.json | ||
| native_code_version=$(jq -r '.nativeCodeVersion | to_entries | reduce .[] as $item (0; . as $key | if $item.key | tonumber > $key then $item.key | tonumber else $key end)' app.json) |
There was a problem hiding this comment.
That's cool -- wanted to use jq in the scripts, so just installed an orb 👍
There was a problem hiding this comment.
yeah was thinking I might need to avoid it but doesn't seem so bad, the scripts are all still a bit in flux as I do some more exploration of what ci should look like but doesn't seem too bad
…nto brian/codepush-sdk
|
Going to split this up into a couple PRs since it is doing a few different things and getting large 👍 |
This PR resolves PHIRE-156
Description
Integrates the code push SDK on iOS and Android, for the time being inactive until we get the build and ci scripts in place.
Exposed the staging deploy key in the process, that was rotated.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.