This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[ImageView] Get rid of skipGemini flag
#875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was only a workaround for a temp issue where Gemini couldn’t load private images.
Don’t use MP’s cropping feature, as it won’t know the perfect resolution at data query time.
alloy
commented
Dec 6, 2017
| url | ||
| } | ||
| url(version: "large") | ||
| aspect_ratio |
|
Yep, makes sense! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A flag called
skipGeminiwas added to the image component, which was seemingly only done to work around a problem with Gemini not being able to read images fromhttpssources. However, the issue was apparently resolved with this PR.The flag was never removed and got used in new auction related code 5dde988#diff-741b505d177ba9a6e497cd077987ab45R47
Skip New Tests