This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[home] adds a way to select tab from initial props #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahscott
force-pushed
the
sos-home-select-tab-from-props
branch
from
c62536e
to
2ae8020
Compare
sarahscott
force-pushed
the
sos-home-select-tab-from-props
branch
from
2ae8020
to
091213d
Compare
sarahscott
commented
Dec 11, 2017
| # This fixes a bug in our Home tab view; it can probably be removed when we upgrade to RN 0.50+ | ||
| # See https://github.com/artsy/collector-experience/issues/751 | ||
| react_scrollview_file = '../node_modules/react-native/React/Views/RCTScrollView.m' | ||
| react_scrollview_old_code = 'self.contentOffset = CGPointMake( |
There was a problem hiding this comment.
|
Ace 👌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts the fix for https://github.com/artsy/collector-experience/issues/751
The complete fix will require some updates to eigen. Using this, we can make sure the Home view opens on the Artists tab from the Works For You deep links, and possibly also on the For You tab after onboarding.