-
Notifications
You must be signed in to change notification settings - Fork 152
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #14863 from artsy/DIA-726-stabilize-transitions-be…
…tween-top-nav-items fix: stabilize transitions on top nav
- Loading branch information
Showing
4 changed files
with
146 additions
and
151 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| import { Dropdown } from "@artsy/palette" | ||
| import { Z } from "Apps/Components/constants" | ||
| import { NavBarSubMenu } from "./Menus" | ||
| import { NavBarItemButton, NavBarItemUnfocusableAnchor } from "./NavBarItem" | ||
| import { usePrefetchRoute } from "System/Hooks/usePrefetchRoute" | ||
| import * as DeprecatedAnalyticsSchema from "@artsy/cohesion/dist/DeprecatedSchema" | ||
| import { MenuData } from "Components/NavBar/menuData" | ||
|
|
||
| interface NavBarDropdownPanelProps { | ||
| href: string | ||
| label: string | ||
| menu: MenuData | ||
| contextModule: string | ||
| onMenuEnter: () => void | ||
| handleClick: (event: React.MouseEvent<HTMLAnchorElement, MouseEvent>) => void | ||
| shouldTransition: boolean | ||
| } | ||
|
|
||
| export const NavBarDropdownPanel: React.FC<NavBarDropdownPanelProps> = ({ | ||
| href, | ||
| label, | ||
| menu, | ||
| contextModule, | ||
| onMenuEnter, | ||
| handleClick, | ||
| shouldTransition, | ||
| }) => { | ||
| const { prefetch } = usePrefetchRoute() | ||
|
|
||
| return ( | ||
| <Dropdown | ||
| zIndex={Z.dropdown} | ||
| keepInDOM | ||
| placement="bottom" | ||
| offset={0} | ||
| transition={shouldTransition} | ||
| // eslint-disable-next-line react/no-unstable-nested-components | ||
| dropdown={({ setVisible }) => ( | ||
| <NavBarSubMenu | ||
| menu={menu} | ||
| contextModule={ | ||
| contextModule as DeprecatedAnalyticsSchema.ContextModule | ||
| } | ||
| onClick={() => setVisible(false)} | ||
| /> | ||
| )} | ||
| > | ||
| {({ anchorRef, anchorProps, visible, setVisible }) => { | ||
| const { onMouseEnter, ...restAnchorProps } = anchorProps | ||
|
|
||
| return ( | ||
| <NavBarItemButton | ||
| ref={anchorRef as any} | ||
| active={visible} | ||
| onMouseEnter={e => { | ||
| onMouseEnter?.(e) | ||
| onMenuEnter() | ||
| }} | ||
| {...restAnchorProps} | ||
| > | ||
| <NavBarItemUnfocusableAnchor | ||
| href={href} | ||
| onMouseOver={() => prefetch(href)} | ||
| onClick={event => { | ||
| handleClick(event) | ||
| setTimeout(() => setVisible(false), 100) | ||
| }} | ||
| data-label={label} | ||
| /> | ||
| {label} | ||
| </NavBarItemButton> | ||
| ) | ||
| }} | ||
| </Dropdown> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters