fix(i18n): globally mocks translation function

[dzucconi]

This fixes the mock so that you don't have to use a monkey patched render etc.

[gkartalis]

👌 thanks for fixing that, way much cleaner! Looks good when the pluralization test starts passing 👀

[dzucconi]

@gkartalis @lidimayra what does this mean in this context?

[gkartalis]

not 100% sure what this is referring to since I wasn't involved in the planning/implementation, but I remember some conversations for the actual translations being moved to a 3rd party like transifex or locize , maybe it was something like this 🤔

[lidimayra]

This is actually related to what was commented here: #9797 (comment)

We paired on it a bit, but we never managed to actually make it work, so we decided to move forward without it, as we didn't want it to block the implementation because of this.

[dzucconi]

What's the benefit of doing that vs simply requiring?

[lidimayra]

As I understand, this would be an optimization for the future. The server-side rendering would prevent us from loading unnecessary files if we have several JSON files for different locales.

@araujobarret might have the proper context on this.

[damassi]

this would be an optimization for the future

We should probably cross that bridge when we get there and keep it simple for now

[dzucconi]

Presumably we'd only load this JSON in memory on the server boot — It's not going to affect performance in any meaningful way.

[dzucconi]

We won't be using this option? Is there anything else in this config can we remove?

[dzucconi]

Unrelated but I suspect we can just run an autofix for all of these.